linux-kernel - Re: [PATCH -next] EDAC: aspeed: Remove set but not used variable 'np'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <04f103fb-54b1-4911-8164-44b20bfd1e72@www.fastmail.com>
Date:   Wed, 29 May 2019 10:57:16 +0930
From:   "Andrew Jeffery" <andrew@...id.au>
To:     YueHaibing <yuehaibing@...wei.com>,
        "Stefan M Schaeckeler" <sschaeck@...co.com>,
        "Borislav Petkov" <bp@...en8.de>,
        "Mauro Carvalho Chehab" <mchehab@...nel.org>, james.morse@....com,
        "Joel Stanley" <joel@....id.au>
Cc:     linux-kernel@...r.kernel.org, linux-aspeed@...ts.ozlabs.org,
        linux-edac@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH -next] EDAC: aspeed: Remove set but not used variable 'np'



On Sun, 26 May 2019, at 00:12, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/edac/aspeed_edac.c: In function aspeed_probe:
> drivers/edac/aspeed_edac.c:284:22: warning: variable np set but not 
> used [-Wunused-but-set-variable]
> 
> It is never used and can be removed.
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Reviewed-by: Andrew Jeffery <andrew@...id.au>

> ---
>  drivers/edac/aspeed_edac.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/edac/aspeed_edac.c b/drivers/edac/aspeed_edac.c
> index 11833c0a5d07..5634437bb39d 100644
> --- a/drivers/edac/aspeed_edac.c
> +++ b/drivers/edac/aspeed_edac.c
> @@ -281,15 +281,11 @@ static int aspeed_probe(struct platform_device *pdev)
>  	struct device *dev = &pdev->dev;
>  	struct edac_mc_layer layers[2];
>  	struct mem_ctl_info *mci;
> -	struct device_node *np;
>  	struct resource *res;
>  	void __iomem *regs;
>  	u32 reg04;
>  	int rc;
>  
> -	/* setup regmap */
> -	np = dev->of_node;
> -
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	if (!res)
>  		return -ENOENT;
> -- 
> 2.17.1
> 
> 
>