lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 29 May 2019 10:05:04 +0100 From: Charles Keepax <ckeepax@...nsource.cirrus.com> To: Chanwoo Choi <cw00.choi@...sung.com> CC: <myungjoo.ham@...sung.com>, <patches@...nsource.cirrus.com>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] extcon: arizona: Correct error handling on regmap_update_bits_check On Wed, May 29, 2019 at 02:37:06PM +0900, Chanwoo Choi wrote: > Hi, > > On 19. 5. 29. 오전 1:50, Charles Keepax wrote: > > Ensure the case when regmap_update_bits_check fails and the change > > variable is not updated is handled correctly. > > > > Signed-off-by: Charles Keepax <ckeepax@...nsource.cirrus.com> > > --- > > regmap_update_bits_check(arizona->regmap, ARIZONA_MIC_DETECT_1, > > ARIZONA_MICD_ENA, 0, > > You better to check the return value as the part of this patch. > Ok I will add it, I hadn't as it was kinda pointless the driver is being unbound and if this doesn't work the regulator stuff will flag the error anyway. But I guess one more error message to make it even more clear where the issue is can't hurt. Thanks, Charles
Powered by blists - more mailing lists