linux-kernel - Re: [PATCH 4/5] ALSA: fireface: Use ULL suffixes for 64-bit constants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hsgsxtvzi.wl-tiwai@suse.de>
Date:   Wed, 29 May 2019 12:07:13 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     "Takashi Sakamoto" <o-takashi@...amocchi.jp>
Cc:     "Geert Uytterhoeven" <geert@...ux-m68k.org>,
        <alsa-devel@...a-project.org>, "Arnd Bergmann" <arnd@...db.de>,
        "David S . Miller" <davem@...emloft.net>,
        "Cong Wang" <xiyou.wangcong@...il.com>,
        "Igor Konopko" <igor.j.konopko@...el.com>,
        "Clemens Ladisch" <clemens@...isch.de>,
        "Matias Bjorling" <mb@...htnvm.io>,
        <linux-afs@...ts.infradead.org>,
        "Eran Ben Elisha" <eranbe@...lanox.com>,
        "Jiri Pirko" <jiri@...lanox.com>,
        "Jamal Hadi Salim" <jhs@...atatu.com>,
        "Mohit P . Tahiliani" <tahiliani@...k.edu.in>,
        "Dan Carpenter" <dan.carpenter@...cle.com>,
        "Joe Perches" <joe@...ches.com>,
        "Jaroslav Kysela" <perex@...ex.cz>,
        "David Howells" <dhowells@...hat.com>,
        <linux-block@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH 4/5] ALSA: fireface: Use ULL suffixes for 64-bit constants

On Wed, 29 May 2019 11:57:31 +0200,
Takashi Sakamoto wrote:
> 
> Hi,
> 
> On Tue, May 28, 2019 at 04:24:23PM +0200, Geert Uytterhoeven wrote:
> > With gcc 4.1:
> > 
> >     sound/firewire/fireface/ff-protocol-latter.c: In function ‘latter_switch_fetching_mode’:
> >     sound/firewire/fireface/ff-protocol-latter.c:97: warning: integer constant is too large for ‘long’ type
> >     sound/firewire/fireface/ff-protocol-latter.c: In function ‘latter_begin_session’:
> >     sound/firewire/fireface/ff-protocol-latter.c:170: warning: integer constant is too large for ‘long’ type
> >     sound/firewire/fireface/ff-protocol-latter.c:197: warning: integer constant is too large for ‘long’ type
> >     sound/firewire/fireface/ff-protocol-latter.c:205: warning: integer constant is too large for ‘long’ type
> >     sound/firewire/fireface/ff-protocol-latter.c: In function ‘latter_finish_session’:
> >     sound/firewire/fireface/ff-protocol-latter.c:214: warning: integer constant is too large for ‘long’ type
> > 
> > Fix this by adding the missing "ULL" suffixes.
> > Add the same suffix to the last constant, to maintain consistency.
> > 
> > Fixes: fd1cc9de64c2ca6c ("ALSA: fireface: add support for Fireface UCX")
> > Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> > ---
> >  sound/firewire/fireface/ff-protocol-latter.c | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> Thanks for your care.
> 
> Reviewed-by: Takashi Sakamoto <o-takashi@...amocchi.jp>

Applied to sound git tree now.  Thanks.


Takashi