linux-kernel - RE: [PATCH net-next v4 1/5] net: stmmac: enable clause 45 mdio support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <78EB27739596EE489E55E81C33FEC33A0B9333BC@DE02WEMBXB.internal.synopsys.com>
Date:   Wed, 29 May 2019 10:16:50 +0000
From:   Jose Abreu <Jose.Abreu@...opsys.com>
To:     Voon Weifeng <weifeng.voon@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Giuseppe Cavallaro" <peppe.cavallaro@...com>,
        Andrew Lunn <andrew@...n.ch>,
        "Florian Fainelli" <f.fainelli@...il.com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        biao huang <biao.huang@...iatek.com>,
        Ong Boon Leong <boon.leong.ong@...el.com>,
        Kweh Hock Leong <hock.leong.kweh@...el.com>
Subject: RE: [PATCH net-next v4 1/5] net: stmmac: enable clause 45 mdio
 support

From: Voon Weifeng <weifeng.voon@...el.com>
Date: Wed, May 29, 2019 at 17:58:23

> +static void stmmac_mdio_c45_setup(struct stmmac_priv *priv, int phyreg,
> +				  u32 *val, u32 *data)
> +{
> +	unsigned int reg_shift = priv->hw->mii.reg_shift;
> +	unsigned int reg_mask = priv->hw->mii.reg_mask;

Reverse christmas tree here. You also should align the function variables 
with the opening parenthesis of the function here and in the remaining 
series.

Otherwise this patch looks good to me.

Thanks,
Jose Miguel Abreu