linux-kernel - RE: [PATCH net-next v4 3/5] net: stmmac: add xpcs function hooks into main driver and ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <78EB27739596EE489E55E81C33FEC33A0B933429@DE02WEMBXB.internal.synopsys.com>
Date:   Wed, 29 May 2019 10:23:57 +0000
From:   Jose Abreu <Jose.Abreu@...opsys.com>
To:     Voon Weifeng <weifeng.voon@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Giuseppe Cavallaro" <peppe.cavallaro@...com>,
        Andrew Lunn <andrew@...n.ch>,
        "Florian Fainelli" <f.fainelli@...il.com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        biao huang <biao.huang@...iatek.com>,
        Ong Boon Leong <boon.leong.ong@...el.com>,
        Kweh Hock Leong <hock.leong.kweh@...el.com>
Subject: RE: [PATCH net-next v4 3/5] net: stmmac: add xpcs function hooks
 into main driver and ethtool

From: Voon Weifeng <weifeng.voon@...el.com>
Date: Wed, May 29, 2019 at 17:58:25

> +/**
> + *  xPCS_interrupt - xPCS ISR
> + *  @irq: interrupt number.
> + *  @dev_id: to pass the net device pointer.
> + *  Description: this is the xPCS interrupt service routine.
> + */

Please remove all JAVA docs from the series unless they are really 
useful. This looks like it's stating the obvious and just pollutes the 
eyes.

> +static irqreturn_t xpcs_interrupt(int irq, void *dev_id)
> +{
> +	struct net_device *ndev = (struct net_device *)dev_id;
> +	struct stmmac_priv *priv = netdev_priv(ndev);
> +	irqreturn_t ret = IRQ_NONE;
> +
> +	if (unlikely(!ndev)) {

This is a useless check because you already dereference the pointer when 
you assign "priv" variable.

Thanks,
Jose Miguel Abreu