linux-kernel - Re: [PATCH RESEND 2/7] csky: entry: Remove unneeded need

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190529014841.GA23749@guoren-Inspiron-7460>
Date:   Wed, 29 May 2019 09:48:41 +0800
From:   Guo Ren <guoren@...nel.org>
To:     Valentin Schneider <valentin.schneider@....com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND 2/7] csky: entry: Remove unneeded need_resched()
 loop

Thx Valentin,

You are right, Approved.

Best Regards
 Guo Ren

On Tue, May 28, 2019 at 11:48:43AM +0100, Valentin Schneider wrote:
> Since the enabling and disabling of IRQs within preempt_schedule_irq()
> is contained in a need_resched() loop, we don't need the outer arch
> code loop.
> 
> Signed-off-by: Valentin Schneider <valentin.schneider@....com>
> Cc: Guo Ren <guoren@...nel.org>
> ---
>  arch/csky/kernel/entry.S | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/arch/csky/kernel/entry.S b/arch/csky/kernel/entry.S
> index a7e84ccccbd8..679afbcc2001 100644
> --- a/arch/csky/kernel/entry.S
> +++ b/arch/csky/kernel/entry.S
> @@ -292,11 +292,7 @@ ENTRY(csky_irq)
>  	ldw	r8, (r9, TINFO_FLAGS)
>  	btsti	r8, TIF_NEED_RESCHED
>  	bf	2f
> -1:
>  	jbsr	preempt_schedule_irq	/* irq en/disable is done inside */
> -	ldw	r7, (r9, TINFO_FLAGS)	/* get new tasks TI_FLAGS */
> -	btsti	r7, TIF_NEED_RESCHED
> -	bt	1b			/* go again */
>  #endif
>  2:
>  	jmpi	ret_from_exception
> -- 
> 2.20.1
>