linux-kernel - Re: [PATCH] vt: configurable number of console devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b52aaaed-5efb-ae1f-68c0-80b150388219@suse.cz>
Date:   Wed, 29 May 2019 13:03:29 +0200
From:   Jiri Slaby <jslaby@...e.cz>
To:     Trevor Bourget <tgb.kernel@...il.com>, gregkh@...uxfoundation.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vt: configurable number of console devices

On 28. 05. 19, 6:31, Trevor Bourget wrote:
> --- a/include/uapi/linux/vt.h
> +++ b/include/uapi/linux/vt.h
> @@ -8,9 +8,13 @@
>   * resizing).
>   */
>  #define MIN_NR_CONSOLES 1       /* must be at least 1 */
> +#ifdef CONFIG_MAX_NR_CONSOLES
> +#define MAX_NR_CONSOLES CONFIG_MAX_NR_CONSOLES

This is an uapi header. Will the #ifdef work there? As I don't think
CONFIG_* (i.e. autoconf.h) is available in userspace...

Also, I am not sure if there is any consumer of this macro in userspace
at all -- so what are the possible effects of this being "incorrect"?

BTW having headers from one kernel and booting another with different
settings makes this definition also incorrect. The same as for e.g. the
HZ constant. Again, not sure if this is a problem at all.

thanks,
-- 
js
suse labs