linux-kernel - Re: [PATCH v5 5/7] iommu/vt-d: Handle PCI bridge RMRR device scopes in intel_iommu_get_resv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bb457306-805a-c618-3f96-4ae53c02e19a@linux.intel.com>
Date:   Wed, 29 May 2019 10:13:21 +0800
From:   Lu Baolu <baolu.lu@...ux.intel.com>
To:     Eric Auger <eric.auger@...hat.com>, eric.auger.pro@...il.com,
        joro@...tes.org, iommu@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org, dwmw2@...radead.org,
        robin.murphy@....com
Cc:     baolu.lu@...ux.intel.com, jean-philippe.brucker@....com,
        alex.williamson@...hat.com
Subject: Re: [PATCH v5 5/7] iommu/vt-d: Handle PCI bridge RMRR device scopes
 in intel_iommu_get_resv_regions

Hi,

On 5/28/19 7:50 PM, Eric Auger wrote:
> In the case the RMRR device scope is a PCI-PCI bridge, let's check
> the device belongs to the PCI sub-hierarchy.


This looks good to me.

Reviewed-by: Lu Baolu <baolu.lu@...ux.intel.com>

Best regards,
Baolu

> 
> Fixes: 0659b8dc45a6 ("iommu/vt-d: Implement reserved region get/put callbacks")
> 
> Signed-off-by: Eric Auger <eric.auger@...hat.com>
> ---
>   drivers/iommu/intel-iommu.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
> index 35508687f178..9302351818ab 100644
> --- a/drivers/iommu/intel-iommu.c
> +++ b/drivers/iommu/intel-iommu.c
> @@ -5496,7 +5496,8 @@ static void intel_iommu_get_resv_regions(struct device *device,
>   			struct iommu_resv_region *resv;
>   			size_t length;
>   
> -			if (i_dev != device)
> +			if (i_dev != device &&
> +			    !is_downstream_to_pci_bridge(device, i_dev))
>   				continue;
>   
>   			length = rmrr->end_address - rmrr->base_address + 1;
>