linux-kernel - Re: [REVIEW][PATCHv2 03/26] signal/arm64: Use force_sig not force_sig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190529151227.GF11154@fuggles.cambridge.arm.com>
Date:   Wed, 29 May 2019 16:12:27 +0100
From:   Will Deacon <will.deacon@....com>
To:     "Eric W. Biederman" <ebiederm@...ssion.com>
Cc:     linux-kernel@...r.kernel.org,
        Linux Containers <containers@...ts.linux-foundation.org>,
        Oleg Nesterov <oleg@...hat.com>, linux-arch@...r.kernel.org,
        Dave Martin <Dave.Martin@....com>,
        James Morse <james.morse@....com>
Subject: Re: [REVIEW][PATCHv2 03/26] signal/arm64: Use force_sig not
 force_sig_fault for SIGKILL

On Fri, May 24, 2019 at 05:36:41PM -0500, Eric W. Biederman wrote:
> Will Deacon <will.deacon@....com> writes:
> 
> > On Thu, May 23, 2019 at 03:59:20PM -0500, Eric W. Biederman wrote:
> >> Will Deacon <will.deacon@....com> writes:
> >> 
> >> > On Thu, May 23, 2019 at 11:11:19AM -0500, Eric W. Biederman wrote:
> >> >> diff --git a/arch/arm64/kernel/traps.c b/arch/arm64/kernel/traps.c
> >> >> index ade32046f3fe..e45d5b440fb1 100644
> >> >> --- a/arch/arm64/kernel/traps.c
> >> >> +++ b/arch/arm64/kernel/traps.c
> >> >> @@ -256,7 +256,10 @@ void arm64_force_sig_fault(int signo, int code, void __user *addr,
> >> >>  			   const char *str)
> >> >>  {
> >> >>  	arm64_show_signal(signo, str);
> >> >> -	force_sig_fault(signo, code, addr, current);
> >> >> +	if (signo == SIGKILL)
> >> >> +		force_sig(SIGKILL, current);
> >> >> +	else
> >> >> +		force_sig_fault(signo, code, addr, current);
> >> >>  }
> >> >
> >> > Acked-by: Will Deacon <will.deacon@....com>
> >> >
> >> > Are you planning to send this series on, or would you like me to pick this
> >> > into the arm64 tree?
> >> 
> >> I am planning on taking this through siginfo tree, unless it causes
> >> problems.
> >
> > Okey doke, it would just be nice to see this patch land in 5.2, that's
> > all.
> 
> As this does not appear to have any real world consequences I am aiming
> at 5.3.  If someone else would like to take it and feed it to Linus
> sooner I won't object.

Thanks. I've picked this patch up as part of the arm64 fixes I plan to send
for -rc3.

Will