linux-kernel - Re: [PATCH net-next] net: dsa: sja1105: Make static_config_check_memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+h21hp=AAfK_Syvu1wSD8gH7hNhbE8FbH=hM0Nt=bzxBWxVRQ@mail.gmail.com>
Date:   Wed, 29 May 2019 18:24:40 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        linux-kernel@...r.kernel.org, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: dsa: sja1105: Make static_config_check_memory_size
 static

On Wed, 29 May 2019 at 17:35, YueHaibing <yuehaibing@...wei.com> wrote:
>
> Fix sparse warning:
>
> drivers/net/dsa/sja1105/sja1105_static_config.c:446:1: warning:
>  symbol 'static_config_check_memory_size' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/net/dsa/sja1105/sja1105_static_config.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/sja1105/sja1105_static_config.c b/drivers/net/dsa/sja1105/sja1105_static_config.c
> index b3c992b0abb0..7e90e62da389 100644
> --- a/drivers/net/dsa/sja1105/sja1105_static_config.c
> +++ b/drivers/net/dsa/sja1105/sja1105_static_config.c
> @@ -442,7 +442,7 @@ const char *sja1105_static_config_error_msg[] = {
>                 "vl-forwarding-parameters-table.partspc.",
>  };
>
> -sja1105_config_valid_t
> +static sja1105_config_valid_t
>  static_config_check_memory_size(const struct sja1105_table *tables)
>  {
>         const struct sja1105_l2_forwarding_params_entry *l2_fwd_params;
> --
> 2.17.1
>
>

Acked-by: Vladimir Oltean <olteanv@...il.com>