[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190529153836.GF18589@dhcp22.suse.cz>
Date: Wed, 29 May 2019 17:38:36 +0200
From: Michal Hocko <mhocko@...nel.org>
To: Kirill Tkhai <ktkhai@...tuozzo.com>
Cc: akpm@...ux-foundation.org, daniel.m.jordan@...cle.com,
linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: Fix recent_rotated history
On Tue 28-05-19 19:09:02, Kirill Tkhai wrote:
> Johannes pointed that after commit 886cf1901db9
> we lost all zone_reclaim_stat::recent_rotated
> history. This commit fixes that.
>
> Fixes: 886cf1901db9 "mm: move recent_rotated pages calculation to shrink_inactive_list()"
> Reported-by: Johannes Weiner <hannes@...xchg.org>
> Signed-off-by: Kirill Tkhai <ktkhai@...tuozzo.com>
I didn't get to review the original bug series but this one looks
obviously correct.
Acked-by: Michal Hocko <mhocko@...e.com>
> ---
> mm/vmscan.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index d9c3e873eca6..1d49329a4d7d 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -1953,8 +1953,8 @@ shrink_inactive_list(unsigned long nr_to_scan, struct lruvec *lruvec,
> if (global_reclaim(sc))
> __count_vm_events(item, nr_reclaimed);
> __count_memcg_events(lruvec_memcg(lruvec), item, nr_reclaimed);
> - reclaim_stat->recent_rotated[0] = stat.nr_activate[0];
> - reclaim_stat->recent_rotated[1] = stat.nr_activate[1];
> + reclaim_stat->recent_rotated[0] += stat.nr_activate[0];
> + reclaim_stat->recent_rotated[1] += stat.nr_activate[1];
>
> move_pages_to_lru(lruvec, &page_list);
>
>
--
Michal Hocko
SUSE Labs
Powered by blists - more mailing lists