linux-kernel - Re: [PATCH] usb: dwc2: Fix DMA cache alignment issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 29 May 2019 11:30:39 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Martin Schiller <ms@....tdt.de>,
        Felipe Balbi <felipe.balbi@...ux.intel.com>
Cc:     Minas Harutyunyan <hminas@...opsys.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Antti Seppälä <a.seppala@...il.com>,
        linux-usb@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        Tomasz Figa <tfiga@...omium.org>
Subject: Re: [PATCH] usb: dwc2: Fix DMA cache alignment issues

Hi,

On Sun, Feb 17, 2019 at 10:37 PM Martin Schiller <ms@....tdt.de> wrote:
>
> Insert a padding between data and the stored_xfer_buffer pointer to
> ensure they are not on the same cache line.
>
> Otherwise, the stored_xfer_buffer gets corrupted for IN URBs on
> non-cache-coherent systems. (In my case: Lantiq xRX200 MIPS)
>
> Fixes: 3bc04e28a030 ("usb: dwc2: host: Get aligned DMA in a more supported way")
> Fixes: 56406e017a88 ("usb: dwc2: Fix DMA alignment to start at allocated boundary")
> Signed-off-by: Martin Schiller <ms@....tdt.de>
> ---
>  drivers/usb/dwc2/hcd.c | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)

This patch has been in the back of my mind for a while bug I never got
around to it.  Today I was debugging memory corruption problems when
using a webcam on dwc2 on rk3288-veyron-jerry.  This patch appears to
solve my problems nicely.  Thanks!

Tested-by: Douglas Anderson <dianders@...omium.org>
Reviewed-by: Douglas Anderson <dianders@...omium.org>
Cc: <stable@...r.kernel.org>