lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 29 May 2019 20:04:34 -0700 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: linux-kernel@...r.kernel.org Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, stable@...r.kernel.org, Wen Yang <wen.yang99@....com.cn>, Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, Srinivas Kandagatla <srinivas.kandagatla@...aro.org>, Vinod Koul <vkoul@...nel.org>, alsa-devel@...a-project.org, Sasha Levin <sashal@...nel.org>, Dan Carpenter <dan.carpenter@...cle.com> Subject: [PATCH 5.1 276/405] ASoC: wcd9335: fix a leaked reference by adding missing of_node_put [ Upstream commit 64b92de9603f22b5455da925ee57268ef7fb4e80 ] The call to of_parse_phandle returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: ./sound/soc/codecs/wcd9335.c:5193:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 5183, but without a correspon ding object release within this function. Signed-off-by: Wen Yang <wen.yang99@....com.cn> Cc: Liam Girdwood <lgirdwood@...il.com> Cc: Mark Brown <broonie@...nel.org> Cc: Jaroslav Kysela <perex@...ex.cz> Cc: Takashi Iwai <tiwai@...e.com> Cc: Srinivas Kandagatla <srinivas.kandagatla@...aro.org> Cc: Vinod Koul <vkoul@...nel.org> Cc: Dan Carpenter <dan.carpenter@...cle.com> (commit_signer:1/11=9%,authored:1/11=9%) Cc: alsa-devel@...a-project.org Cc: linux-kernel@...r.kernel.org Signed-off-by: Mark Brown <broonie@...nel.org> Signed-off-by: Sasha Levin <sashal@...nel.org> --- sound/soc/codecs/wcd9335.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c index 981f88a5f6154..a04a7cedd99de 100644 --- a/sound/soc/codecs/wcd9335.c +++ b/sound/soc/codecs/wcd9335.c @@ -5188,6 +5188,7 @@ static int wcd9335_slim_status(struct slim_device *sdev, wcd->slim = sdev; wcd->slim_ifc_dev = of_slim_get_device(sdev->ctrl, ifc_dev_np); + of_node_put(ifc_dev_np); if (!wcd->slim_ifc_dev) { dev_err(dev, "Unable to get SLIM Interface device\n"); return -EINVAL; -- 2.20.1
Powered by blists - more mailing lists