linux-kernel - RE: [PATCH 2/2] zstd: use U16 data type for rankPos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190530091628epcms5p2ea7c6837c3ab3963815585d8b16c7838@epcms5p2>
Date:   Thu, 30 May 2019 14:46:28 +0530
From:   Vaneet Narang <v.narang@...sung.com>
To:     Maninder Singh <maninder1.s@...sung.com>,
        "terrelln@...com" <terrelln@...com>,
        "herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "keescook@...omium.org" <keescook@...omium.org>,
        "gustavo@...eddedor.com" <gustavo@...eddedor.com>
CC:     "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        AMIT SAHRAWAT <a.sahrawat@...sung.com>,
        PANKAJ MISHRA <pankaj.m@...sung.com>,
        Vaneet Narang <v.narang@...sung.com>
Subject: RE: [PATCH 2/2] zstd: use U16 data type for rankPos

[Reminder] Any Comments?

>rankPos structure variables value can not be more than 512.
>So it can easily be declared as U16 rather than U32.
 
>It will reduce stack usage of HUF_sort from 256 bytes to 128 bytes
 
>original:
>e24ddc01        sub     sp, sp, #256    ; 0x100
 
>changed:
>e24dd080        sub     sp, sp, #128    ; 0x80
 
Regards,
Vaneet Narang