linux-kernel - Re: [PATCH V2] drivers: i2c: tegra: fix checkpatch defects

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <911e52ed-8f3c-583a-7610-e38723219eca@gmail.com>
Date:   Thu, 30 May 2019 14:43:05 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Bitan Biswas <bbiswas@...dia.com>,
        Laxman Dewangan <ldewangan@...dia.com>,
        Thierry Reding <treding@...dia.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        linux-i2c@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Shardar Mohammed <smohammed@...dia.com>,
        Sowjanya Komatineni <skomatineni@...dia.com>,
        Mantravadi Karthik <mkarthik@...dia.com>
Subject: Re: [PATCH V2] drivers: i2c: tegra: fix checkpatch defects

30.05.2019 14:36, Dmitry Osipenko пишет:
> 30.05.2019 9:14, Bitan Biswas пишет:
>> Fix checkpatch.pl warning(s)/error(s)/check(s) in i2c-tegra.c
>> except for BUG/BUG_ON checks
> 
> Please turn the BUG_ON's into WARN_ON's. The machine won't go on fire,
> hence there is absolutely no good reason in making system unusable on a
> software bug. BUG_ON may be more useful for development, but not for a
> casual daily usage.
> 
>> Signed-off-by: Bitan Biswas <bbiswas@...dia.com>
>> ---
> 
>> @@ -1034,7 +1038,7 @@ static int tegra_i2c_xfer_msg(struct tegra_i2c_dev *i2c_dev,
>>  	u32 *buffer = NULL;
>>  	int err = 0;
>>  	bool dma;
>> -	u16 xfer_time = 100;
>> +	u16 xfer_tm = 100;
> 
> What's wrong with the "time"? I'm finding the "xfer_tm" as a very
> unintuitive naming.
> 

Also, please don't version patch as v2 if v1 was never sent out.