linux-kernel - Re: [PATCH 2/2] edac: add support for Amazon's Annapurna Labs EDAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bc749161a8b8640ebdf78d693111d5350514638.camel@perches.com>
Date:   Thu, 30 May 2019 06:04:00 -0700
From:   Joe Perches <joe@...ches.com>
To:     hhhawa@...zon.com, Greg KH <gregkh@...uxfoundation.org>
Cc:     robh+dt@...nel.org, mark.rutland@....com, bp@...en8.de,
        mchehab@...nel.org, james.morse@....com, davem@...emloft.net,
        nicolas.ferre@...rochip.com, paulmck@...ux.ibm.com,
        dwmw@...zon.co.uk, benh@...zon.com, ronenk@...zon.com,
        talel@...zon.com, jonnyc@...zon.com, hanochu@...zon.com,
        linux-edac@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] edac: add support for Amazon's Annapurna Labs EDAC

On Thu, 2019-05-30 at 15:52 +0300, hhhawa@...zon.com wrote:
> On 5/30/19 2:57 PM, Greg KH wrote:
> > On Thu, May 30, 2019 at 01:15:29PM +0300, Hanna Hawa wrote:
> > > +static void al_a57_edac_cpumerrsr(void *arg)
> > > +{
> > > +	struct edac_device_ctl_info *edac_dev =
> > > +		(struct edac_device_ctl_info *)arg;
> > No need for casting anything here, just assign it.  Doesn't checkpatch
> > catch this type of thing these days?  You did run it, right?
> 
> I did, but checkpatch didn't catch this. I'll fix in next patch-set.
> 
> Thanks for your review.

checkpatch is brainless about the types of variables/arguments.

coccinelle is another very useful tool so you could also run
scripts/coccicheck on your sources.

see: Documentation/dev-tools/coccinelle.rst