linux-kernel - RE: [PATCH 1/1] Drivers: hv: vmbus: Break out ISA independent parts of mshyperv.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BYAPR21MB1221CD9AAEF9BCC6A5AF0C7AD7180@BYAPR21MB1221.namprd21.prod.outlook.com>
Date:   Thu, 30 May 2019 00:05:25 +0000
From:   Michael Kelley <mikelley@...rosoft.com>
To:     vkuznets <vkuznets@...hat.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "olaf@...fle.de" <olaf@...fle.de>,
        "apw@...onical.com" <apw@...onical.com>,
        "jasowang@...hat.com" <jasowang@...hat.com>,
        "marcelo.cerri@...onical.com" <marcelo.cerri@...onical.com>,
        Sunil Muthuswamy <sunilmut@...rosoft.com>,
        KY Srinivasan <kys@...rosoft.com>
Subject: RE: [PATCH 1/1] Drivers: hv: vmbus: Break out ISA independent parts
 of mshyperv.h

From: Vitaly Kuznetsov <vkuznets@...hat.com> Sent: Wednesday, May 29, 2019 8:41 AM
> >  void __init hyperv_init(void);
> 
> I would actually expect to see hyperv_init() on all architectures so it
> can probably go to 'generic' too.
> 

Actually not.  The declaration is not needed on all architectures.   On ARM64,
hyperv_init() and ms_hyperv_init_platform() are folded into one routine, and
it's not externally referenced.  So the declaration isn't needed.  The hypervisor
initialization approach is fairly different on ARM64.

[....]
> 
> This seems a little bit too much, in particular, I think we don't need
> 
>  #include <linux/interrupt.h>
>  #include <linux/clocksource.h>
>  #include <linux/irq.h>
>  #include <linux/irqdesc.h>
> 
> we'll need 'struct pt_regs' definition but I'd suggest we use
> 
>  #include <linux/ptrace.h>
> 
> or even
> 
>  #include <asm/ptrace.h>
> 

Agreed.  I'll spin a v2 with this cleaned up.

Michael