linux-kernel - Re: dm-init: fix 2 incorrect use of kstrndup()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190530161103.GA30026@redhat.com>
Date:   Thu, 30 May 2019 12:11:03 -0400
From:   Mike Snitzer <snitzer@...hat.com>
To:     Gen Zhang <blackgod016574@...il.com>
Cc:     Bart Van Assche <bvanassche@....org>, dm-devel@...hat.com,
        agk@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: dm-init: fix 2 incorrect use of kstrndup()

On Wed, May 29 2019 at 11:24am -0400,
Gen Zhang <blackgod016574@...il.com> wrote:

> On Wed, May 29, 2019 at 05:23:53AM -0700, Bart Van Assche wrote:
> > On 5/28/19 6:33 PM, Gen Zhang wrote:
> > > In drivers/md/dm-init.c, kstrndup() is incorrectly used twice.
> > > 
> > > It should be: char *kstrndup(const char *s, size_t max, gfp_t gfp);
> > 
> > Should the following be added to this patch?
> > 
> > Fixes: 6bbc923dfcf5 ("dm: add support to directly boot to a mapped
> > device") # v5.1.
> > Cc: stable
> > 
> > Thanks,
> > 
> > Bart.
> Personally, I am not quite sure about this question, because I am not 
> the maintainer of this part.

Yes, it should have the tags Bart suggested.

I'll take care it.

Thanks,
Mike