lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 30 May 2019 11:26:30 -0700 (PDT) From: David Miller <davem@...emloft.net> To: mkubecek@...e.cz Cc: netdev@...r.kernel.org, vivien.didelot@...il.com, linux-kernel@...r.kernel.org, kernel@...oirfairelinux.com, linville@...hat.com, f.fainelli@...il.com Subject: Re: [PATCH net-next] ethtool: copy reglen to userspace From: Michal Kubecek <mkubecek@...e.cz> Date: Thu, 30 May 2019 10:27:22 +0200 > I believe this should be handled by ethtool_get_regs(), either by > returning an error or by only copying data up to original regs.len > passed by userspace. The former seems more correct but broken userspace > software would suddenly start to fail where it "used to work". The > latter would be closer to current behaviour but it would mean that > broken userspace software might nerver notice there is something wrong. I therefore think we need to meticulously fixup all of these adjustments of regs.len before adjusting the copy call here in generic ethtool.
Powered by blists - more mailing lists