linux-kernel - Re: [PATCH] falcon: pass valid pointer from ef4_enqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190530.114517.2038537000773947362.davem@davemloft.net>
Date:   Thu, 30 May 2019 11:45:17 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     92siuyang@...il.com
Cc:     ecree@...arflare.com, mhabets@...arflare.com, fw@...len.de,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] falcon: pass valid pointer from ef4_enqueue_unwind.

From: Young Xiao <92siuyang@...il.com>
Date: Wed, 29 May 2019 10:15:39 +0800

> The bytes_compl and pkts_compl pointers passed to ef4_dequeue_buffers
> cannot be NULL. Add a paranoid warning to check this condition and fix
> the one case where they were NULL.
> 
> Signed-off-by: Young Xiao <92siuyang@...il.com>

EF4_TX_BUF_SKB will be clear in this situation, so your patch is not
necessary.