linux-kernel - Re: [PATCH] isdn: hisax: isac: fix a possible concurrency use-after-free bug in ISAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190530.123833.494901093768074533.davem@davemloft.net>
Date:   Thu, 30 May 2019 12:38:33 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     92siuyang@...il.com
Cc:     isdn@...ux-pingi.de, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] isdn: hisax: isac: fix a possible concurrency
 use-after-free bug in ISAC_l1hw()

From: Young Xiao <92siuyang@...il.com>
Date: Wed, 29 May 2019 16:48:59 +0800

> In drivers/isdn/hisax/isac.c, the function isac_interrupt() and
> ISAC_l1hw() may be concurrently executed.
> 
> ISAC_l1hw()
>     line 499: if (!cs->tx_skb)
> 
> isac_interrupt()
>     line 250: dev_kfree_skb_irq(cs->tx_skb);
> 
> Thus, a possible concurrency use-after-free bug may occur in ISAC_l1hw().
 ...
> +		spin_lock_irqsave(&cs->lock, flags);
>  		if (!cs->tx_skb) {
>  			test_and_clear_bit(FLG_L1_PULL_REQ, &st->l1.Flags);
>  			st->l1.l1l2(st, PH_PULL | CONFIRM, NULL);
>  		} else
>  			test_and_set_bit(FLG_L1_PULL_REQ, &st->l1.Flags);
> +		spin_unlock_irqrestore(&cs->lock, flags);

Nothing in this code accesses the cs->tx_skb object.  It is just a logic test
upon whether it is NULL or not.

I'm not applying stuff like this, sorry.

You have to show how something can actually go wrong when fixing a bug.