linux-kernel - Re: [PATCH] staging: kpc2000: Fix build failure caused by wrong include file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190530211950.GA17581@kroah.com>
Date:   Thu, 30 May 2019 14:19:50 -0700
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: kpc2000: Fix build failure caused by wrong
 include file

On Thu, May 30, 2019 at 04:33:42AM -0700, Guenter Roeck wrote:
> xtensa:allmodconfig fails to build.
> 
> arch/xtensa/include/asm/uaccess.h: In function 'clear_user':
> arch/xtensa/include/asm/uaccess.h:40:22: error:
> 	implicit declaration of function 'uaccess_kernel'
> 
> uaccess_kernel() is declared in linux/uaccess.h, not asm/uaccess.h.
> 
> Fixes: 7df95299b94a ("staging: kpc2000: Add DMA driver")
> Cc: Matt Sickler <Matt.Sickler@...tronics.com>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> ---
>  drivers/staging/kpc2000/kpc_dma/fileops.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/kpc2000/kpc_dma/fileops.c b/drivers/staging/kpc2000/kpc_dma/fileops.c
> index 5741d2b49a7d..e741fa753ca1 100644
> --- a/drivers/staging/kpc2000/kpc_dma/fileops.c
> +++ b/drivers/staging/kpc2000/kpc_dma/fileops.c
> @@ -8,7 +8,7 @@
>  #include <linux/errno.h>    /* error codes */
>  #include <linux/types.h>    /* size_t */
>  #include <linux/cdev.h>
> -#include <asm/uaccess.h>    /* copy_*_user */
> +#include <linux/uaccess.h>    /* copy_*_user */
>  #include <linux/aio.h>      /* aio stuff */
>  #include <linux/highmem.h>
>  #include <linux/pagemap.h>

Already fixed by e00839f38823 ("staging: kpc2000: fix build error on
xtensa") in my staging-linus branch.

thanks,

greg k-h