linux-kernel - Re: [PATCH 0/2] arm64: smp: Include smp_plat.h from smp.h

Open Source and information security mailing list archives

Date:   Fri, 31 May 2019 00:17:35 +0100
From:   Russell King - ARM Linux admin <linux@...linux.org.uk>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     linux-arm-kernel@...ts.infradead.org, marc.zyngier@....com,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        open list <linux-kernel@...r.kernel.org>,
        Shaokun Zhang <zhangshaokun@...ilicon.com>
Subject: Re: [PATCH 0/2] arm64: smp: Include smp_plat.h from smp.h

On Thu, May 30, 2019 at 04:14:28PM -0700, Florian Fainelli wrote:
> On 5/30/19 4:05 PM, Florian Fainelli wrote:
> > Hi ARM64 maintainers,
> > 
> > This patch series aims at enabling irq-bcm7038-l1.c on
> > ARM64/ARCH_BRCMSTB, this driver makes use of cpu_logical_map[] and in
> > order to avoid adding a CONFIG_ARM64 conditional inclusion of
> > smp_plat.h, instead smp.h includes smp_plat.h, which is in turn included
> > by linux/smp.h.
> > 
> > If you like the approach, I would suggest to carry that through the
> > Broadcom ARM64 SoC pull request for 5.3.
> 
> ARM (32-bit) needs the same thing kind of thing so a conditional include
> may be appropriate after all...

The whole idea of the smp_plat.h vs smp.h separation is to avoid
including lots of arch-private stuff in the rest of the kernel
build, thereby exposing arch-private stuff to the world.  I'm be
opposed to that.

> 
> > 
> > Thank you!
> > 
> > Florian Fainelli (2):
> >   arm64: smp: Include smp_plat.h from smp.h
> >   arm64: Enable BCM7038_L1_IRQ for ARCH_BRCMSTB
> > 
> >  arch/arm64/Kconfig.platforms      | 1 +
> >  arch/arm64/include/asm/smp.h      | 1 +
> >  arch/arm64/include/asm/smp_plat.h | 1 +
> >  3 files changed, 3 insertions(+)
> > 
> 
> 
> -- 
> Florian
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives