lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 29 May 2019 20:04:37 -0700 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: linux-kernel@...r.kernel.org Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, stable@...r.kernel.org, Hante Meuleman <hante.meuleman@...adcom.com>, Pieter-Paul Giesberts <pieter-paul.giesberts@...adcom.com>, Franky Lin <franky.lin@...adcom.com>, Arend van Spriel <arend.vanspriel@...adcom.com>, Kalle Valo <kvalo@...eaurora.org>, Ben Hutchings <ben.hutchings@...ethink.co.uk> Subject: [PATCH 4.14 023/193] brcmfmac: assure SSID length from firmware is limited From: Arend van Spriel <arend.vanspriel@...adcom.com> commit 1b5e2423164b3670e8bc9174e4762d297990deff upstream. The SSID length as received from firmware should not exceed IEEE80211_MAX_SSID_LEN as that would result in heap overflow. Reviewed-by: Hante Meuleman <hante.meuleman@...adcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesberts@...adcom.com> Reviewed-by: Franky Lin <franky.lin@...adcom.com> Signed-off-by: Arend van Spriel <arend.vanspriel@...adcom.com> Signed-off-by: Kalle Valo <kvalo@...eaurora.org> Cc: Ben Hutchings <ben.hutchings@...ethink.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c @@ -3581,6 +3581,8 @@ brcmf_wowl_nd_results(struct brcmf_if *i } netinfo = brcmf_get_netinfo_array(pfn_result); + if (netinfo->SSID_len > IEEE80211_MAX_SSID_LEN) + netinfo->SSID_len = IEEE80211_MAX_SSID_LEN; memcpy(cfg->wowl.nd->ssid.ssid, netinfo->SSID, netinfo->SSID_len); cfg->wowl.nd->ssid.ssid_len = netinfo->SSID_len; cfg->wowl.nd->n_channels = 1;
Powered by blists - more mailing lists