linux-kernel - Re: linux-next: Tree for May 30 (firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1D63F878-8B7D-4BE4-9FB7-F523C7F473BE@redhat.com>
Date:   Fri, 31 May 2019 02:52:32 +0200
From:   Matteo Croce <mcroce@...hat.com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
CC:     Randy Dunlap <rdunlap@...radead.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Luis Chamberlain <mcgrof@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: linux-next: Tree for May 30 (firmware_loader)

On May 31, 2019 2:06:46 AM GMT+02:00, Stephen Rothwell <sfr@...b.auug.org.au> wrote:
> Hi all,
> 
> On Thu, 30 May 2019 09:10:13 -0700 Randy Dunlap
> <rdunlap@...radead.org> wrote:
> >
> > on i386 or x86_64:
> > when CONFIG_PROC_SYSCTL is not set/enabled:
> > 
> > ld: drivers/base/firmware_loader/fallback_table.o:(.data+0x1c):
> undefined reference to `sysctl_vals'
> > ld: drivers/base/firmware_loader/fallback_table.o:(.data+0x20):
> undefined reference to `sysctl_vals'
> > ld: drivers/base/firmware_loader/fallback_table.o:(.data+0x40):
> undefined reference to `sysctl_vals'
> > ld: drivers/base/firmware_loader/fallback_table.o:(.data+0x44):
> undefined reference to `sysctl_vals'
> 
> Caused by commit
> 
>   6a33853c5773 ("proc/sysctl: add shared variables for range check")
> 
> Added some more cc's

Hi,

Probably the whole firmware_config_table declaration should be under #ifdef CONFIG_PROC_SYSCTL?

I'll look into it, thanks.
-- 
Matteo Croce
per aspera ad upstream