linux-kernel - Re: [PATCH V6] ARM: mach-shmobile: Don't init CNTVOFF/counter if PSCI is available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190531094000.7l32vuvslsijzgxb@verge.net.au>
Date:   Fri, 31 May 2019 11:40:00 +0200
From:   Simon Horman <horms@...ge.net.au>
To:     Oleksandr Tyshchenko <olekstysh@...il.com>
Cc:     linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        julien.grall@....com, magnus.damm@...il.com, linux@...linux.org.uk,
        geert@...ux-m68k.org,
        Oleksandr Tyshchenko <oleksandr_tyshchenko@...m.com>
Subject: Re: [PATCH V6] ARM: mach-shmobile: Don't init CNTVOFF/counter if
 PSCI is available

On Wed, May 29, 2019 at 07:05:00PM +0300, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@...m.com>
> 
> If PSCI is available then most likely we are running on PSCI-enabled
> U-Boot which, we assume, has already taken care of resetting CNTVOFF
> and updating counter module before switching to non-secure mode
> and we don't need to.
> 
> As the psci_smp_available() helper always returns false if CONFIG_SMP
> is disabled, it can't be used safely as an indicator of PSCI usage.
> For that reason, we check for the mandatory PSCI operation to be
> available.
> 
> Please note, an extra check to prevent secure_cntvoff_init() from
> being called for secondary CPUs in headsmp-apmu.S is not needed,
> as SMP code for APMU based system is not executed if PSCI is in use.
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@...m.com>
> CC: Julien Grall <julien.grall@....com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>

Thanks Oleksandr,

applied for inclusion in v5.3.