linux-kernel - Re: [PATCH v1] s390/pkey: Use -ENODEV instead of -EOPNOTSUPP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190531115055.7f5cf64e.cohuck@redhat.com>
Date:   Fri, 31 May 2019 11:50:55 +0200
From:   Cornelia Huck <cohuck@...hat.com>
To:     David Hildenbrand <david@...hat.com>
Cc:     linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org,
        Harald Freudenberger <freude@...ux.ibm.com>,
        Heiko Carstens <heiko.carstens@...ibm.com>,
        Christian Borntraeger <borntraeger@...ibm.com>
Subject: Re: [PATCH v1] s390/pkey: Use -ENODEV instead of -EOPNOTSUPP

On Fri, 31 May 2019 11:36:28 +0200
David Hildenbrand <david@...hat.com> wrote:

> systemd-modules-load.service automatically tries to load the pkey module
> on systems that have MSA.
> 
> Pkey also requires the MSA3 facility and a bunch of subfunctions.
> Failing with -EOPNOTSUPP makes "systemd-modules-load.service" fail on
> any system that does not have all needed subfunctions. For example,
> when running under QEMU TCG (but also on systems where protected keys
> are disabled via the HMC).
> 
> Let's use -ENODEV, so systemd-modules-load.service properly ignores
> failing to load the pkey module because of missing HW functionality.
> 
> Cc: Harald Freudenberger <freude@...ux.ibm.com>
> Cc: Heiko Carstens <heiko.carstens@...ibm.com>
> Cc: Cornelia Huck <cohuck@...hat.com>
> Cc: Christian Borntraeger <borntraeger@...ibm.com>
> Signed-off-by: David Hildenbrand <david@...hat.com>
> ---
>  drivers/s390/crypto/pkey_api.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Looking at what other modules return when needed features are missing,
this looks like the right thing to do.

Reviewed-by: Cornelia Huck <cohuck@...hat.com>