linux-kernel - Re: [PATCH -next] crypto: atmel-i2c - Fix build error while CRC16 set to m

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 31 May 2019 11:53:22 +0200
From:   Ard Biesheuvel <ard.biesheuvel@...aro.org>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" 
        <linux-crypto@...r.kernel.org>
Subject: Re: [PATCH -next] crypto: atmel-i2c - Fix build error while CRC16 set
 to m

On Fri, 31 May 2019 at 11:50, YueHaibing <yuehaibing@...wei.com> wrote:
>
> If CRYPTO_DEV_ATMEL_ECC is set m, which select CRC16 to m,
> while CRYPTO_DEV_ATMEL_SHA204A is set to y, building fails.
>
> drivers/crypto/atmel-i2c.o: In function `atmel_i2c_checksum':
> atmel-i2c.c:(.text+0x16): undefined reference to `crc16'
>
> Add CRC16 dependency to CRYPTO_DEV_ATMEL_SHA204A, and also make
> CRYPTO_DEV_ATMEL_ECC depends on CRC16.
>

Please use 'select' in both cases, not 'depends on'


> Reported-by: Hulk Robot <hulkci@...wei.com>
> Fixes: da001fb651b0 ("crypto: atmel-i2c - add support for SHA204A random number generator")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/crypto/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
> index fe01a99..7aebff8 100644
> --- a/drivers/crypto/Kconfig
> +++ b/drivers/crypto/Kconfig
> @@ -528,7 +528,7 @@ config CRYPTO_DEV_ATMEL_ECC
>         depends on I2C
>         select CRYPTO_DEV_ATMEL_I2C
>         select CRYPTO_ECDH
> -       select CRC16
> +       depends on CRC16
>         help
>           Microhip / Atmel ECC hw accelerator.
>           Select this if you want to use the Microchip / Atmel module for
> @@ -540,6 +540,7 @@ config CRYPTO_DEV_ATMEL_ECC
>  config CRYPTO_DEV_ATMEL_SHA204A
>         tristate "Support for Microchip / Atmel SHA accelerator and RNG"
>         depends on I2C
> +       depends on CRC16
>         select CRYPTO_DEV_ATMEL_I2C
>         select HW_RANDOM
>         help
> --
> 2.7.4
>
>