linux-kernel - Re: [PATCH] staging: comedi: Remove variable runflags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8292224d-9c4a-d29e-4a86-d3352fcd2be1@mev.co.uk>
Date:   Fri, 31 May 2019 11:25:54 +0100
From:   Ian Abbott <abbotti@....co.uk>
To:     Nishka Dasgupta <nishkadg.linux@...il.com>,
        hsweeten@...ionengravers.com, gregkh@...uxfoundation.org,
        olsonse@...ch.edu, jkhasdev@...il.com,
        giulio.benetti@...ronovasrl.com, nishadkamdar@...il.com,
        kas.sandesh@...il.com, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: comedi: Remove variable runflags

On 30/05/2019 21:51, Nishka Dasgupta wrote:
> Remove variable runflags and use its value directly. Issue found with
> checkpatch.
> 
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@...il.com>
> ---
>   drivers/staging/comedi/comedi_fops.c | 8 ++------
>   1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> index f6d1287c7b83..b84ee9293903 100644
> --- a/drivers/staging/comedi/comedi_fops.c
> +++ b/drivers/staging/comedi/comedi_fops.c
> @@ -676,16 +676,12 @@ EXPORT_SYMBOL_GPL(comedi_is_subdevice_running);
>   
>   static bool __comedi_is_subdevice_running(struct comedi_subdevice *s)
>   {
> -	unsigned int runflags = __comedi_get_subdevice_runflags(s);
> -
> -	return comedi_is_runflags_running(runflags);
> +	return comedi_is_runflags_running(__comedi_get_subdevice_runflags(s));
>   }
>   
>   bool comedi_can_auto_free_spriv(struct comedi_subdevice *s)
>   {
> -	unsigned int runflags = __comedi_get_subdevice_runflags(s);
> -
> -	return runflags & COMEDI_SRF_FREE_SPRIV;
> +	return __comedi_get_subdevice_runflags(s) & COMEDI_SRF_FREE_SPRIV;
>   }
>   
>   /**
> 

I couldn't reproduce this checkpatch issue, even with '--subjective'.

-- 
-=( Ian Abbott <abbotti@....co.uk> || Web: www.mev.co.uk )=-
-=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 02862268.  Registered address:    )=-
-=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-