linux-kernel - re: security/loadpin: Allow to exclude specific file types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <73fac64c-fe49-4738-49a4-0afe668eed94@canonical.com>
Date:   Fri, 31 May 2019 11:46:29 +0100
From:   Colin Ian King <colin.king@...onical.com>
To:     Ke Wu <mikewu@...gle.com>,
        James Morris <jamorris@...ux.microsoft.com>,
        Kees Cook <keescook@...omium.org>,
        "Serge E. Hallyn" <serge@...lyn.com>,
        linux-security-module@...r.kernel.org
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: re: security/loadpin: Allow to exclude specific file types

Hi,

Static analysis with Coverity on linux-next has found a potential issue
with the following commit:

commit 1633a4f04cc171fc638deb5c95af96032d3c591b
Author: Ke Wu <mikewu@...gle.com>
Date:   Thu May 30 12:22:08 2019 -0700

    security/loadpin: Allow to exclude specific file types

209                for (j = 0; j < ARRAY_SIZE(kernel_read_file_str); j++) {
210                        if (strcmp(cur, kernel_read_file_str[j]) == 0) {
211                                pr_info("excluding: %s\n",
212                                        kernel_read_file_str[j]);

CID 81977 (#1 of 1): Out-of-bounds write
overrun-local: Overrunning array ignore_read_file_id of 8 4-byte
elements at element index 8 (byte offset 35) using index j (which
evaluates to 8).

213                                ignore_read_file_id[j] = 1;

According to Coverity ignore_read_file_id is an array of 8 integers.
However, ARRAY_SIZE(kernel_read_file_str) is 9, so we have an out of
bounds write on ignore_read_file[j] when j is 8.

Colin