linux-kernel - Re: [PATCHv6 3/4] drm/omap: add framedone interrupt support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bbe14265-4499-4a55-ef94-9def2df365d7@ti.com>
Date:   Fri, 31 May 2019 15:23:32 +0300
From:   Tomi Valkeinen <tomi.valkeinen@...com>
To:     Sebastian Reichel <sre@...nel.org>
CC:     Tony Lindgren <tony@...mide.com>, Pavel Machek <pavel@....cz>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        "H. Nikolaus Schaller" <hns@...delico.com>,
        <dri-devel@...ts.freedesktop.org>, <linux-omap@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <kernel@...labora.com>
Subject: Re: [PATCHv6 3/4] drm/omap: add framedone interrupt support

On 30/05/2019 00:55, Sebastian Reichel wrote:

> Oh sorry, I missed the part that omap_irq_wait_init() actually
> enables the framedone irq. It should be enough to just drop the
> warning (and the curly brackets) to keep existing behaviour. The
> code exits early with the above warning for any existing code (since
> that does not register a framedone handler). DSI on the other hand
> does not reach the omap_irq_wait_init() part. Regarding combining
> the logic: I don't think there is anything to combine right now.
> It should be possible to simplify the logic after DSI has been
> converted to drm_panel style, since this will move the update logic
> for the screen content from the panel driver to DSI core.
> 
> TLDR: It's enough to remove the warning. Do you need a new
> submission for this?

Ok. No, I can edit the patch.

Nikolaus, are you able to test DSI videomode with these patches?

  Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki