linux-kernel - Re: [PATCH -next] x86: apuv2: Make two symbols static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 31 May 2019 14:27:28 +0200
From:   "Enrico Weigelt, metux IT consult" <lkml@...ux.net>
To:     YueHaibing <yuehaibing@...wei.com>, info@...ux.net,
        dvhart@...radead.org, andy@...radead.org, linus.walleij@...aro.org
Cc:     linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org,
        linux-gpio@...r.kernel.org
Subject: Re: [PATCH -next] x86: apuv2: Make two symbols static

On 29.05.19 16:38, YueHaibing wrote:
> Fix sparse warnings:
> 
> drivers/platform/x86/pcengines-apuv2.c:80:27: warning: symbol 'gpios_led_table' was not declared. Should it be static?
> drivers/platform/x86/pcengines-apuv2.c:113:27: warning: symbol 'gpios_key_table' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/platform/x86/pcengines-apuv2.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/pcengines-apuv2.c b/drivers/platform/x86/pcengines-apuv2.c
> index c1ca931e1fab..b0d3110ae378 100644
> --- a/drivers/platform/x86/pcengines-apuv2.c
> +++ b/drivers/platform/x86/pcengines-apuv2.c
> @@ -77,7 +77,7 @@ static const struct gpio_led_platform_data apu2_leds_pdata = {
>  	.leds		= apu2_leds,
>  };
>  
> -struct gpiod_lookup_table gpios_led_table = {
> +static struct gpiod_lookup_table gpios_led_table = {
>  	.dev_id = "leds-gpio",
>  	.table = {
>  		GPIO_LOOKUP_IDX(AMD_FCH_GPIO_DRIVER_NAME, APU2_GPIO_LINE_LED1,
> @@ -110,7 +110,7 @@ static const struct gpio_keys_platform_data apu2_keys_pdata = {
>  	.name		= "apu2-keys",
>  };
>  
> -struct gpiod_lookup_table gpios_key_table = {
> +static struct gpiod_lookup_table gpios_key_table = {
>  	.dev_id = "gpio-keys-polled",
>  	.table = {
>  		GPIO_LOOKUP_IDX(AMD_FCH_GPIO_DRIVER_NAME, APU2_GPIO_LINE_MODESW,
> 

thanks.


Acked-By: Enrico Weigelt, metux IT consult <info@...ux.net>


--mtx

-- 
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@...ux.net -- +49-151-27565287