linux-kernel - Re: clean some unneeded #ifdef MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1559315724.2878.7.camel@linux.ibm.com>
Date:   Fri, 31 May 2019 18:15:24 +0300
From:   James Bottomley <jejb@...ux.ibm.com>
To:     "Enrico Weigelt, metux IT consult" <info@...ux.net>,
        linux-kernel@...r.kernel.org
Cc:     rjw@...ysocki.net, viresh.kumar@...aro.org, jdelvare@...e.com,
        linux@...ck-us.net, khalid@...ehiking.org,
        martin.petersen@...cle.com, aacraid@...rosemi.com,
        linux-pm@...r.kernel.org, linux-hwmon@...r.kernel.org,
        linux-scsi@...r.kernel.org
Subject: Re: clean some unneeded #ifdef MODULE

On Fri, 2019-05-31 at 17:09 +0200, Enrico Weigelt, metux IT consult
wrote:
> Hi folks,
> 
> here're some patches that clean up uncessary cases of #ifdef MODULE.
> These ifdef's just exlude MODULE_DEVICE_TABLE's when the kernel is
> built w/o module support. As MODULE_DEVICE_TABLE() macro already
> checks for that, these extra #ifdef's shouldn't be necessary.

Isn't the problem the #ifdefs are trying to solve a complaint about an
unused variable in the non-module case? if so, is that fixed some other
way?

James