linux-kernel - Re: [PATCH v3 5/6] dpaa_eth: fix iova handling for contiguous frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190531163229.GA8708@infradead.org>
Date:   Fri, 31 May 2019 09:32:29 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     laurentiu.tudor@....com
Cc:     netdev@...r.kernel.org, madalin.bucur@....com, roy.pledge@....com,
        camelia.groza@....com, leoyang.li@....com,
        linux-kernel@...r.kernel.org, Joakim.Tjernlund@...inera.com,
        iommu@...ts.linux-foundation.org, linuxppc-dev@...ts.ozlabs.org,
        davem@...emloft.net, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 5/6] dpaa_eth: fix iova handling for contiguous frames

On Thu, May 30, 2019 at 05:19:50PM +0300, laurentiu.tudor@....com wrote:
> +static phys_addr_t dpaa_iova_to_phys(const struct dpaa_priv *priv,
> +				     dma_addr_t addr)
> +{
> +	return priv->domain ? iommu_iova_to_phys(priv->domain, addr) : addr;
> +}

Again, a driver using the iommu API must not call iommu_* APIs.

This chane is not acceptable.