linux-kernel - Re: [net-next v2] hinic: add LRO support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 31 May 2019 14:53:04 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     xuechaojing@...wei.com
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        luoshaokai@...wei.com, cloud.wangxiaoyun@...wei.com,
        chiqijun@...wei.com, wulike1@...wei.com
Subject: Re: [net-next v2] hinic: add LRO support

From: Xue Chaojing <xuechaojing@...wei.com>
Date: Fri, 31 May 2019 05:47:30 +0000

> +	if ((err) || (out_param)) {

Too many parenthesis, just "if (err || out_param)" is fine.

> @@ -51,6 +51,22 @@ static unsigned int rx_weight = 64;
>  module_param(rx_weight, uint, 0644);
>  MODULE_PARM_DESC(rx_weight, "Number Rx packets for NAPI budget (default=64)");
>  
> +static unsigned int set_lro_timer = 16;
> +module_param(set_lro_timer, uint, 0444);
> +MODULE_PARM_DESC(set_lro_timer, "Set lro timer in micro second, valid range is 1 - 1024, default is 16");

I also said your changes were a non-starter with all of these module
parameters.

I am not looking at this patch until you find a way to remove them.

Thank you.