linux-kernel - Re: [PATCH] arch: s390: use struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190601102104.GA3600@osiris>
Date:   Sat, 1 Jun 2019 12:21:04 +0200
From:   Heiko Carstens <heiko.carstens@...ibm.com>
To:     xiaolinkui <xiaolinkui@...inos.cn>
Cc:     linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arch: s390: use struct_size() in kmalloc()

On Fri, May 17, 2019 at 03:15:17PM +0800, xiaolinkui wrote:
> Use the new struct_size() helper to keep code simple.
> 
> Signed-off-by: xiaolinkui <xiaolinkui@...inos.cn>
> ---
>  arch/s390/include/asm/idals.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/s390/include/asm/idals.h b/arch/s390/include/asm/idals.h
> index 15578fd..6fb7ace 100644
> --- a/arch/s390/include/asm/idals.h
> +++ b/arch/s390/include/asm/idals.h
> @@ -122,8 +122,7 @@ idal_buffer_alloc(size_t size, int page_order)
> 
>  	nr_ptrs = (size + IDA_BLOCK_SIZE - 1) >> IDA_SIZE_LOG;
>  	nr_chunks = (4096 << page_order) >> IDA_SIZE_LOG;
> -	ib = kmalloc(sizeof(struct idal_buffer) + nr_ptrs*sizeof(void *),
> -		     GFP_DMA | GFP_KERNEL);
> +	ib = kmalloc(struct_size(ib, data, nr_ptrs), GFP_DMA | GFP_KERNEL);
>  	if (ib == NULL)
>  		return ERR_PTR(-ENOMEM);
>  	ib->size = size;

Applied, thanks.