linux-kernel - Re: [PATCH -mm] mm, swap: Fix bad swap file entry warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <ba248cf9f2344d0db6d029ae82a32c52BN6PR1801MB2065F9E5FF6F9E8928879290CB190@BN6PR1801MB2065.namprd18.prod.outlook.com>
Date:   Sat, 1 Jun 2019 04:25:35 +0000
From:   Yuri Norov <ynorov@...vell.com>
To:     Qian Cai <cai@....pw>, Dexuan-Linux Cui <dexuan.linux@...il.com>,
        "Mike Kravetz" <mike.kravetz@...cle.com>
CC:     "Huang, Ying" <ying.huang@...el.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
        Andrea Parri <andrea.parri@...rulasolutions.com>,
        "Paul E . McKenney" <paulmck@...ux.vnet.ibm.com>,
        Michal Hocko <mhocko@...e.com>,
        Minchan Kim <minchan@...nel.org>,
        Hugh Dickins <hughd@...gle.com>,
        Dexuan Cui <decui@...rosoft.com>,
        "v-lide@...rosoft.com" <v-lide@...rosoft.com>,
        "Yury Norov" <yury.norov@...il.com>
Subject: Re: [PATCH -mm] mm, swap: Fix bad swap file entry warning

(Resend as LKML didn't take outlook settings.)

> On Fri, 2019-05-31 at 11:27 -0700, Dexuan-Linux Cui wrote:
> > Hi,
> > Did you know about the panic reported here:
> >  https://marc.info/?t=155930773000003&r=1&w=2
> > 
> > "Kernel panic - not syncing: stack-protector: Kernel stack is
> > corrupted in: write_irq_affinity.isra> "
> > 
> > This panic is reported on PowerPC and x86.
> > 
> > In the case of x86, we see a lot of "get_swap_device: Bad swap file entry"
> > errors before the panic:
> > 
> > ...
> > [   24.404693] get_swap_device: Bad swap file entry 5800000000000001
> > [   24.408702] get_swap_device: Bad swap file entry 5c00000000000001
> > [   24.412510] get_swap_device: Bad swap file entry 6000000000000001
> > [   24.416519] get_swap_device: Bad swap file entry 6400000000000001
> > [   24.420217] get_swap_device: Bad swap file entry 6800000000000001
> > [   24.423921] get_swap_device: Bad swap file entry 6c00000000000001

[..]

I don't have a panic, but I observe many lines like this.

> Looks familiar,
>
> https://lore.kernel.org/lkml/1559242868.6132.35.camel@lca.pw/
>
> I suppose Andrew might be better of reverting the whole series first before Yury
> came up with a right fix, so that other people who is testing linux-next don't
> need to waste time for the same problem.

I didn't observe any problems with this series on top of 5.1, and there's a fix for swap\
that eliminates the problem on top of current next for me:
https://lkml.org/lkml/2019/5/30/1630

Could you please test my series with the patch above?

Thanks,
Yury