linux-kernel - Re: [PATCH] drm/msm/adreno: Ensure that the zap shader region is big enough

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 31 May 2019 22:48:04 -0700
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Jordan Crouse <jcrouse@...eaurora.org>
Cc:     freedreno@...ts.freedesktop.org, Sean Paul <sean@...rly.run>,
        Kees Cook <keescook@...omium.org>,
        linux-arm-msm@...r.kernel.org,
        Sharat Masetty <smasetty@...eaurora.org>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        Douglas Anderson <dianders@...omium.org>,
        Rob Clark <robdclark@...il.com>,
        David Airlie <airlied@...ux.ie>,
        Jonathan Marek <jonathan@...ek.ca>,
        Mamta Shukla <mamtashukla555@...il.com>,
        Daniel Vetter <daniel@...ll.ch>
Subject: Re: [PATCH] drm/msm/adreno: Ensure that the zap shader region is big
 enough

On Fri 31 May 15:09 PDT 2019, Jordan Crouse wrote:

> Before loading the zap shader we should ensure that the reserved memory
> region is big enough to hold the loaded file.
> 
> Signed-off-by: Jordan Crouse <jcrouse@...eaurora.org>

Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>

> ---
> 
>  drivers/gpu/drm/msm/adreno/adreno_gpu.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> index 6f7f411..3db8e49 100644
> --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> @@ -67,7 +67,6 @@ static int zap_shader_load_mdt(struct msm_gpu *gpu, const char *fwname,
>  		return ret;
>  
>  	mem_phys = r.start;
> -	mem_size = resource_size(&r);
>  
>  	/* Request the MDT file for the firmware */
>  	fw = adreno_request_fw(to_adreno_gpu(gpu), fwname);
> @@ -83,6 +82,13 @@ static int zap_shader_load_mdt(struct msm_gpu *gpu, const char *fwname,
>  		goto out;
>  	}
>  
> +	if (mem_size > resource_size(&r)) {
> +		DRM_DEV_ERROR(dev,
> +			"memory region is too small to load the MDT\n");
> +		ret = -E2BIG;
> +		goto out;
> +	}
> +
>  	/* Allocate memory for the firmware image */
>  	mem_region = memremap(mem_phys, mem_size,  MEMREMAP_WC);
>  	if (!mem_region) {
> -- 
> 2.7.4
>