linux-kernel - [PATCH] pci: ibmphp: add check of return value from pci_hp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sun,  2 Jun 2019 16:30:12 +0200
From:   Emanuel Bennici <benniciemanuel78@...il.com>
To:     linux-kernel@...r.kernel.org
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>, Joe Perches <joe@...ches.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Lukas Wunner <lukas@...ner.de>,
        Tyrel Datwyler <tyreld@...ux.vnet.ibm.com>,
        Sebastian Ott <sebott@...ux.ibm.com>
Subject: [PATCH] pci: ibmphp: add check of return value from pci_hp_register()

Check the return value of pci_hp_register() in Function
ebda_rsrc_controller()

Signed-off-by: Emanuel Bennici <benniciemanuel78@...il.com>
---
 drivers/pci/hotplug/ibmphp_ebda.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/hotplug/ibmphp_ebda.c b/drivers/pci/hotplug/ibmphp_ebda.c
index 11a2661dc062..7e523ce071b3 100644
--- a/drivers/pci/hotplug/ibmphp_ebda.c
+++ b/drivers/pci/hotplug/ibmphp_ebda.c
@@ -896,10 +896,17 @@ static int __init ebda_rsrc_controller(void)
 
 	}			/* each hpc  */
 
+	int result = 0;
 	list_for_each_entry(tmp_slot, &ibmphp_slot_head, ibm_slot_list) {
 		snprintf(name, SLOT_NAME_SIZE, "%s", create_file_name(tmp_slot));
-		pci_hp_register(&tmp_slot->hotplug_slot,
-			pci_find_bus(0, tmp_slot->bus), tmp_slot->device, name);
+		result = pci_hp_register(&tmp_slot->hotplug_slot,
+					 pci_find_bus(0, tmp_slot->bus),
+					 tmp_slot->device, name);
+
+		if (result) {
+			err("pci_hp_register failed with error %d\n", result);
+			goto error;
+		}
 	}
 
 	print_ebda_hpc();
-- 
2.19.1