linux-kernel - Re: [PATCH] pci: hotplug: ibmphp: Add white space to Debug Message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <16f2f9c2e34d59cdf9a7bf0f5111251c284e0a3b.camel@perches.com>
Date:   Sun, 02 Jun 2019 09:16:57 -0700
From:   Joe Perches <joe@...ches.com>
To:     benniciemanuel78@...il.com, linux-kernel@...r.kernel.org
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Lukas Wunner <lukas@...ner.de>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Tyrel Datwyler <tyreld@...ux.vnet.ibm.com>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] pci: hotplug: ibmphp: Add white space to Debug Message

On Sun, 2019-06-02 at 18:00 +0200, Emanuel Bennici wrote:
> Add a Whitespace between '-' and 'Exit' to keep the log messages consistent
[]
> diff --git a/drivers/pci/hotplug/ibmphp_core.c b/drivers/pci/hotplug/ibmphp_core.c
[]
> @@ -890,7 +890,7 @@ static int set_bus(struct slot *slot_cur)
>  	/* This is for x440, once Brandon fixes the firmware,
>  	will not need this delay */
>  	msleep(1000);
> -	debug("%s -Exit\n", __func__);
> +	debug("%s - Exit\n", __func__);

These sorts of messages should just be deleted
and the function tracer (ftrace) used instead.