linux-kernel - checkpatch query regarding .c and .h files..

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <25942.1559494964@turing-police>
Date:   Sun, 02 Jun 2019 13:02:44 -0400
From:   "Valdis Klētnieks" <valdis.kletnieks@...edu>
To:     Rob Herring <robh@...nel.org>, Andy Whitcroft <apw@...onical.com>,
        Joe Perches <joe@...ches.com>
Cc:     linux-kernel@...r.kernel.org
Subject: checkpatch query regarding .c and .h files..

scripts/checkpatch.pl contains this code near line 3070:

                               if ($realfile =~ /\.(h|s|S)$/) {
                                        $comment = '/*';
                                } elsif ($realfile =~ /\.(c|dts|dtsi)$/) {
                                        $comment = '//';
                                } elsif (($checklicenseline == 2) || $realfile =~ /\.(sh|pl|py|awk|tc)$/) {
                                        $comment = '#';
                                } elsif ($realfile =~ /\.rst$/) {
                                        $comment = '..';
                                }

Was there a specific reason why .h files have /* */ and .c files have C89 // on
the SPDX comment line?

Would anybody like a patch that fixed checkpatch to allow either flavor on .c and .h files?
(I know I would, I just blew close to an hour trying to figure out why it whined about a
SPDX in a .h file I'm getting ready to upstream...)


Content of type "application/pgp-signature" skipped