linux-kernel - Re: [PATCH] crypto: ux500 - fix license comment syntax error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNASoaiBCObeEPO-hcrg9ftsGq2QWXoG+R8TWv1z53HJvXw@mail.gmail.com>
Date:   Sun, 2 Jun 2019 09:37:43 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Alex Xu <alex_y_xu@...oo.ca>
Cc:     Greg KH <gregkh@...uxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-crypto@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
        allison@...utok.net, alexios.zavras@...el.com, swinslow@...il.com,
        rfontana@...hat.com, linux-spdx@...r.kernel.org,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] crypto: ux500 - fix license comment syntax error

On Sun, Jun 2, 2019 at 4:41 AM Alex Xu <alex_y_xu@...oo.ca> wrote:
>
> Quoting Greg KH (2019-06-01 16:29:07)
> > On Sat, Jun 01, 2019 at 10:49:43AM -0400, Alex Xu (Hello71) wrote:
> > > Causes error: drivers/crypto/ux500/cryp/Makefile:5: *** missing
> > > separator.  Stop.
> > >
> > > Fixes: af873fcecef5 ("treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 194")
> > > Signed-off-by: Alex Xu (Hello71) <alex_y_xu@...oo.ca>
> > > ---
> > >  drivers/crypto/ux500/cryp/Makefile | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Also, how did 0-day not catch this?  Is this an odd configuration that
> > it can not build?
>
> I had to run "make clean" to get the error.

I think this copyright block is ugly.


# SPDX-License-Identifier: GPL-2.0-only
#
# Copyright (C) ST-Ericsson SA 2010
# Author: shujuan.chen@...ricsson.com for ST-Ericsson.

looks nicer IMHO.




-- 
Best Regards
Masahiro Yamada