linux-kernel - Re: [PATCH 8/8] staging: rtl8712: Fixed CamelCase in struct _adapter from drv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHkoDDZc4ua7N8Y-rQfgBCXARu83mpQwYDp0sYOUE0AGmvsiFg@mail.gmail.com>
Date:   Sun, 2 Jun 2019 15:42:40 +0530
From:   Deepak Mishra <linux.dkm@...il.com>
To:     Joe Perches <joe@...ches.com>, linux-kernel@...r.kernel.org
Cc:     wlanfae <wlanfae@...ltek.com>, gregkh@...uxfoundation.org,
        Larry.Finger@...inger.net, florian.c.schilhabel@...glemail.com,
        himadri18.07@...il.com, straube.linux@...il.com
Subject: Re: [PATCH 8/8] staging: rtl8712: Fixed CamelCase in struct _adapter
 from drv_types.h

On Sat, Jun 01, 2019 at 12:26:02PM -0700, Joe Perches wrote:
> On Sun, 2019-06-02 at 00:13 +0530, Deepak Mishra wrote:
> > This patch fixes CamelCase blnEnableRxFF0Filter by renaming it
> > to bln_enable_rx_ff0_filter in drv_types.h and related files rtl871x_cmd.c
> > xmit_linux.c
>
> One could also improve this by removing the
> hungarian like bln_ prefix and simplify the
> name of the boolean variable.
>
 Thank you for your suggestion and I am modifying accordingly and
 sending a V2 patch.
> > diff --git a/drivers/staging/rtl8712/drv_types.h b/drivers/staging/rtl8712/drv_types.h
> []
> > @@ -164,7 +164,7 @@ struct _adapter {
> >     struct iw_statistics iwstats;
> >     int pid; /*process id from UI*/
> >     struct work_struct wk_filter_rx_ff0;
> > -   u8 blnEnableRxFF0Filter;
> > +   u8 bln_enable_rx_ff0_filter;
>
> e.g.:
>
>       bool enable_rx_ff0_filter;
>
> > diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
> []
> > @@ -238,7 +238,7 @@ u8 r8712_sitesurvey_cmd(struct _adapter *padapter,
> >     mod_timer(&pmlmepriv->scan_to_timer,
> >               jiffies + msecs_to_jiffies(SCANNING_TIMEOUT));
> >     padapter->ledpriv.LedControlHandler(padapter, LED_CTL_SITE_SURVEY);
> > -   padapter->blnEnableRxFF0Filter = 0;
> > +   padapter->bln_enable_rx_ff0_filter = 0;
>
>       padapter->enable_rx_ff0_filter = false;
>
> > diff --git a/drivers/staging/rtl8712/xmit_linux.c b/drivers/staging/rtl8712/xmit_linux.c
> []
> > @@ -103,11 +103,11 @@ void r8712_SetFilter(struct work_struct *work)
> >     r8712_write8(padapter, 0x117, newvalue);
> >
> >     spin_lock_irqsave(&padapter->lockRxFF0Filter, irqL);
> > -   padapter->blnEnableRxFF0Filter = 1;
> > +   padapter->bln_enable_rx_ff0_filter = 1;
>
>       padapter->enable_rx_ff0_filter = true;
>
> etc...
>
> Then you could rename padapter to adapter, and maybe
> "struct _adapter" to something more sensible like
> "struct rtl8712dev" etc...
>
  Thanks for suggestion again. I am going to take it in a diferent patchset
  and submit that.

> And one day, hopefully sooner than later, realtek will
> improve their driver software base and help eliminate
> all the duplicated non-style defects across the family
> of drivers for their hardware...
>

Best regards

Deepak Mishra