linux-kernel - Re: [RFC PATCH 39/57] drivers: mux: Use class_find_device_by_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b1166eea-8bd4-f3ae-5e0a-72e1f507a142@axentia.se>
Date:   Mon, 3 Jun 2019 18:39:58 +0000
From:   Peter Rosin <peda@...ntia.se>
To:     Suzuki K Poulose <suzuki.poulose@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "rafael@...nel.org" <rafael@...nel.org>
Subject: Re: [RFC PATCH 39/57] drivers: mux: Use class_find_device_by_of_node
 helper

On 2019-06-03 18:45, Suzuki K Poulose wrote:
> Hi Peter,

> Sorry about that. The routine is a wrapper to class_find_device()
> which uses a generic routine to match the of_node, instead of the
> driver specific of_dev_node_match(). The series adds such wrappers for
> {bus/drivers/class}_find_device(). Unfortunately I didn't add
> individual driver maintainers to the patches, which add those wrappers.
> For the moment, please find the link below for the patch :
> 
> https://lkml.kernel.org/r/1559577023-558-29-git-send-email-suzuki.poulose@arm.com
> 
> 
> I will try to address it in the next revision.

For the record, that patch references some other new function
"device_match_of_node" for which I do not have a definition. But with
the above link, I was able to find it without too much effort.

All looks ok to me, so, if you fix that blank line thing,

Reviewed-by: Peter Rosin <peda@...ntia.se>

Cheers,
Peter