Message-ID: <20190603203452.GC14526@tower.DHCP.thefacebook.com>
Date:   Mon, 3 Jun 2019 20:34:57 +0000
From:   Roman Gushchin <guro@...com>
To:     "Tobin C. Harding" <me@...in.cc>
CC:     "Tobin C. Harding" <tobin@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Matthew Wilcox <willy@...radead.org>,
        "Alexander Viro" <viro@....linux.org.uk>,
        Christoph Hellwig <hch@...radead.org>,
        "Pekka Enberg" <penberg@...helsinki.fi>,
        David Rientjes <rientjes@...gle.com>,
        Joonsoo Kim <iamjoonsoo.kim@....com>,
        Christopher Lameter <cl@...ux.com>,
        Miklos Szeredi <mszeredi@...hat.com>,
        Andreas Dilger <adilger@...ger.ca>,
        Waiman Long <longman@...hat.com>,
        Tycho Andersen <tycho@...ho.ws>,
        "Theodore Ts'o" <tytso@....edu>, Andi Kleen <ak@...ux.intel.com>,
        David Chinner <david@...morbit.com>,
        Nick Piggin <npiggin@...il.com>,
        Rik van Riel <riel@...hat.com>,
        Hugh Dickins <hughd@...gle.com>,
        Jonathan Corbet <corbet@....net>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH v5 16/16] dcache: Add CONFIG_DCACHE_SMO

On Mon, Jun 03, 2019 at 02:26:20PM +1000, Tobin C. Harding wrote:
> On Wed, May 29, 2019 at 04:16:51PM +0000, Roman Gushchin wrote:
> > On Wed, May 29, 2019 at 01:54:06PM +1000, Tobin C. Harding wrote:
> > > On Tue, May 21, 2019 at 02:05:38AM +0000, Roman Gushchin wrote:
> > > > On Tue, May 21, 2019 at 11:31:18AM +1000, Tobin C. Harding wrote:
> > > > > On Tue, May 21, 2019 at 12:57:47AM +0000, Roman Gushchin wrote:
> > > > > > On Mon, May 20, 2019 at 03:40:17PM +1000, Tobin C. Harding wrote:
> > > > > > > In an attempt to make the SMO patchset as non-invasive as possible add a
> > > > > > > config option CONFIG_DCACHE_SMO (under "Memory Management options") for
> > > > > > > enabling SMO for the DCACHE.  Whithout this option dcache constructor is
> > > > > > > used but no other code is built in, with this option enabled slab
> > > > > > > mobility is enabled and the isolate/migrate functions are built in.
> > > > > > > 
> > > > > > > Add CONFIG_DCACHE_SMO to guard the partial shrinking of the dcache via
> > > > > > > Slab Movable Objects infrastructure.
> > > > > > 
> > > > > > Hm, isn't it better to make it a static branch? Or basically anything
> > > > > > that allows switching on the fly?
> > > > > 
> > > > > If that is wanted, turning SMO on and off per cache, we can probably do
> > > > > this in the SMO code in SLUB.
> > > > 
> > > > Not necessarily per cache, but without recompiling the kernel.
> > > > > 
> > > > > > It seems that the cost of just building it in shouldn't be that high.
> > > > > > And the question if the defragmentation worth the trouble is so much
> > > > > > easier to answer if it's possible to turn it on and off without rebooting.
> > > > > 
> > > > > If the question is 'is defragmentation worth the trouble for the
> > > > > dcache', I'm not sure having SMO turned off helps answer that question.
> > > > > If one doesn't shrink the dentry cache there should be very little
> > > > > overhead in having SMO enabled.  So if one wants to explore this
> > > > > question then they can turn on the config option.  Please correct me if
> > > > > I'm wrong.
> > > > 
> > > > The problem with a config option is that it's hard to switch over.
> > > > 
> > > > So just to test your changes in production a new kernel should be built,
> > > > tested and rolled out to a representative set of machines (which can be
> > > > measured in thousands of machines). Then if results are questionable,
> > > > it should be rolled back.
> > > > 
> > > > What you're actually guarding is the kmem_cache_setup_mobility() call,
> > > > which can be perfectly avoided using a boot option, for example. Turning
> > > > it on and off completely dynamic isn't that hard too.
> > > 
> > > Hi Roman,
> > > 
> > > I've added a boot parameter to SLUB so that admins can enable/disable
> > > SMO at boot time system wide.  Then for each object that implements SMO
> > > (currently XArray and dcache) I've also added a boot parameter to
> > > enable/disable SMO for that cache specifically (these depend on SMO
> > > being enabled system wide).
> > > 
> > > All three boot parameters default to 'off', I've added a config option
> > > to default each to 'on'.
> > > 
> > > I've got a little more testing to do on another part of the set then the
> > > PATCH version is coming at you :)
> > > 
> > > This is more a courtesy email than a request for comment, but please
> > > feel free to shout if you don't like the method outlined above.
> > > 
> > > Fully dynamic config is not currently possible because currently the SMO
> > > implementation does not support disabling mobility for a cache once it
> > > is turned on, a bit of extra logic would need to be added and some state
> > > stored - I'm not sure it warrants it ATM but that can be easily added
> > > later if wanted.  Maybe Christoph will give his opinion on this.
> > 
> > Perfect!
> 
> Hi Roman,
> 
> I'm about to post PATCH series.  I have removed all the boot time config
> options in contrast to what I stated in this thread.  I feel it requires
> some comment so as not to seem rude to you.  Please feel free to
> re-raise these issues on the series if you feel it is a better place to
> do it than on this thread.
> 
> I still hear you re making testing easier if there are boot parameters.
> I don't have extensive experience testing on a large number of machines
> so I have no basis to contradict what you said.
> 
> It was suggested to me that having switches to turn SMO off implies the
> series is not ready.  I am claiming that SMO _is_ ready and also that it
> has no negative effects (especially on the dcache).  I therefore think
> this comment is pertinent.
> 
> So ... I re-did the boot parameters defaulting to 'on'.  However I could
> then see no reason (outside of testing) to turn them off.  It seems ugly
> to have code that is only required during testing and never after.
> Please correct me if I'm wrong.
> 
> Finally I decided that since adding a boot parameter is trivial that
> hackers could easily add one to test if they wanted to test a specific
> cache.  Otherwise we just test 'patched kernel' vs 'unpatched kernel'.
> Again, please correct me if I'm wrong.
> 
> So, that said, please feel free to voice your opinion as strongly as you
> wish.  I am super appreciative of the time you have already taken to
> look at these patches.  I hope I have made the best technical decision,
> and I am totally open to being told I'm wrong :)

Hi Tobin!

No boot options looks totally fine to me. I just don't like new config
options. No options at all is always the best.

Btw, thank you for this clarification!

I'll definitely try to look into the patchset on this week.

Thanks!

Powered by blists - more mailing lists