linux-kernel - Re: [PATCH net-next v5 3/5] net: stmmac: add xpcs function hooks into main driver and ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 03 Jun 2019 14:54:03 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     weifeng.voon@...el.com
Cc:     mcoquelin.stm32@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, joabreu@...opsys.com,
        peppe.cavallaro@...com, andrew@...n.ch, f.fainelli@...il.com,
        alexandre.torgue@...com, biao.huang@...iatek.com,
        boon.leong.ong@...el.com, hock.leong.kweh@...el.com
Subject: Re: [PATCH net-next v5 3/5] net: stmmac: add xpcs function hooks
 into main driver and ethtool

From: Voon Weifeng <weifeng.voon@...el.com>
Date: Sat,  1 Jun 2019 03:58:12 +0800

> +static bool mac_adjust_link(struct stmmac_priv *priv,
> +			    int *speed, int *duplex)
> +{
> +	bool new_state = false;
> +
> +	u32 ctrl = readl(priv->ioaddr + MAC_CTRL_REG);

Again please don't break up the local variable declarations like this.