linux-kernel - Re: [PATCH -next] usb: host: ohci-st: Remove set but not used variable 'ohci'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0a4ed9eb-6da2-60c7-cf70-192b8ab64286@st.com>
Date:   Mon, 3 Jun 2019 08:53:37 +0000
From:   Patrice CHOTARD <patrice.chotard@...com>
To:     YueHaibing <yuehaibing@...wei.com>,
        "stern@...land.harvard.edu" <stern@...land.harvard.edu>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH -next] usb: host: ohci-st: Remove set but not used
 variable 'ohci'

Hi

On 5/28/19 3:38 PM, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/usb/host/ohci-st.c: In function st_ohci_platform_probe:
> drivers/usb/host/ohci-st.c:135:19: warning: variable ohci set but not used [-Wunused-but-set-variable]
> 
> It's never used, so can be removed.
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/usb/host/ohci-st.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/usb/host/ohci-st.c b/drivers/usb/host/ohci-st.c
> index 992807c9850a..638a92bd2cdc 100644
> --- a/drivers/usb/host/ohci-st.c
> +++ b/drivers/usb/host/ohci-st.c
> @@ -132,7 +132,6 @@ static int st_ohci_platform_probe(struct platform_device *dev)
>  	struct resource *res_mem;
>  	struct usb_ohci_pdata *pdata = &ohci_platform_defaults;
>  	struct st_ohci_platform_priv *priv;
> -	struct ohci_hcd *ohci;
>  	int err, irq, clk = 0;
>  
>  	if (usb_disabled())
> @@ -158,7 +157,6 @@ static int st_ohci_platform_probe(struct platform_device *dev)
>  	platform_set_drvdata(dev, hcd);
>  	dev->dev.platform_data = pdata;
>  	priv = hcd_to_ohci_priv(hcd);
> -	ohci = hcd_to_ohci(hcd);
>  
>  	priv->phy = devm_phy_get(&dev->dev, "usb");
>  	if (IS_ERR(priv->phy)) {
> 

Acked-by: Patrice Chotard <patrice.chotard@...com>

Thanks