linux-kernel - Re: [PATCH 0/2] arm64: smp: Include smp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ebad255-f2c1-d1be-af42-e24c197ab05d@arm.com>
Date:   Mon, 3 Jun 2019 12:09:27 +0100
From:   Marc Zyngier <marc.zyngier@....com>
To:     Russell King - ARM Linux admin <linux@...linux.org.uk>,
        Florian Fainelli <f.fainelli@...il.com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>
Cc:     open list <linux-kernel@...r.kernel.org>,
        Shaokun Zhang <zhangshaokun@...ilicon.com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 0/2] arm64: smp: Include smp_plat.h from smp.h

On 31/05/2019 00:34, Russell King - ARM Linux admin wrote:
> On Thu, May 30, 2019 at 04:20:37PM -0700, Florian Fainelli wrote:
>> On 5/30/19 4:17 PM, Russell King - ARM Linux admin wrote:
>>> On Thu, May 30, 2019 at 04:14:28PM -0700, Florian Fainelli wrote:
>>>> On 5/30/19 4:05 PM, Florian Fainelli wrote:
>>>>> Hi ARM64 maintainers,
>>>>>
>>>>> This patch series aims at enabling irq-bcm7038-l1.c on
>>>>> ARM64/ARCH_BRCMSTB, this driver makes use of cpu_logical_map[] and in
>>>>> order to avoid adding a CONFIG_ARM64 conditional inclusion of
>>>>> smp_plat.h, instead smp.h includes smp_plat.h, which is in turn included
>>>>> by linux/smp.h.
>>>>>
>>>>> If you like the approach, I would suggest to carry that through the
>>>>> Broadcom ARM64 SoC pull request for 5.3.
>>>>
>>>> ARM (32-bit) needs the same thing kind of thing so a conditional include
>>>> may be appropriate after all...
>>>
>>> The whole idea of the smp_plat.h vs smp.h separation is to avoid
>>> including lots of arch-private stuff in the rest of the kernel
>>> build, thereby exposing arch-private stuff to the world.  I'm be
>>> opposed to that.
>>
>> I was on the fence, sent it just in case, but ended up doing this:
>>
>> https://lore.kernel.org/patchwork/patch/1082410/
>>
>> will take patch #2 through the Broadcom ARM64 SoC tree once this patch
>> above gets accepted.
> 
> Well, there's another alternative: we move just what is required from
> smp_plat.h to smp.h.

I think that's the best course of action, and would align arm/arm64 with
mips, sparc, sh, xtensa and parisc.

Florian, do you mind writing these two patches?

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...