linux-kernel - Re: [PATCH] media: cxusb-analog: Use ARRAY_SIZE for cxusub_medion_pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8512e951-03fc-34d0-6dcf-fe9667eba022@xs4all.nl>
Date:   Mon, 3 Jun 2019 14:14:42 +0200
From:   Hans Verkuil <hverkuil@...all.nl>
To:     "Maciej S. Szmigiero" <mail@...iej.szmigiero.name>,
        Michael Krufky <mkrufky@...uxtv.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        linux-media@...r.kernel.org, kbuild test robot <lkp@...el.com>
Subject: Re: [PATCH] media: cxusb-analog: Use ARRAY_SIZE for
 cxusub_medion_pin_config

Hi Maciej,

Thank you for the patch, but I posted a fix for this earlier already:

https://patchwork.linuxtv.org/patch/56441/

I'll drop this patch in favor of the one above. Apologies for not
CC-ing you on my patch, I should have done that.

Regards,

	Hans

On 6/1/19 12:37 AM, Maciej S. Szmigiero wrote:
> Use ARRAY_SIZE for computing element count of cxusub_medion_pin_config
> array as suggested by the kbuild test robot.
> 
> Reported-by: kbuild test robot <lkp@...el.com>
> Signed-off-by: Maciej S. Szmigiero <mail@...iej.szmigiero.name>
> ---
>  drivers/media/usb/dvb-usb/cxusb-analog.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/media/usb/dvb-usb/cxusb-analog.c b/drivers/media/usb/dvb-usb/cxusb-analog.c
> index 9b42ca71c177..51d3cba32b60 100644
> --- a/drivers/media/usb/dvb-usb/cxusb-analog.c
> +++ b/drivers/media/usb/dvb-usb/cxusb-analog.c
> @@ -1622,8 +1622,7 @@ int cxusb_medion_analog_init(struct dvb_usb_device *dvbdev)
>  	/* TODO: setup audio samples insertion */
>  
>  	ret = v4l2_subdev_call(cxdev->cx25840, core, s_io_pin_config,
> -			       sizeof(cxusub_medion_pin_config) /
> -			       sizeof(cxusub_medion_pin_config[0]),
> +			       ARRAY_SIZE(cxusub_medion_pin_config),
>  			       cxusub_medion_pin_config);
>  	if (ret != 0)
>  		dev_warn(&dvbdev->udev->dev,
>