[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1559528827.6663.8.camel@mtkswgap22>
Date: Mon, 3 Jun 2019 10:27:07 +0800
From: Neal Liu <neal.liu@...iatek.com>
To: Sean Wang <sean.wang@...nel.org>
CC: Matt Mackall <mpm@...enic.com>,
Herbert Xu <herbert@...dor.apana.org.au>,
Rob Herring <robh+dt@...nel.org>,
"Mark Rutland" <mark.rutland@....com>,
Matthias Brugger <matthias.bgg@...il.com>,
<linux-crypto@...r.kernel.org>, <devicetree@...r.kernel.org>,
"linux-arm Mailing List" <linux-arm-kernel@...ts.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@...ts.infradead.org>,
lkml <linux-kernel@...r.kernel.org>, <wsd_upstream@...iatek.com>,
Crystal Guo <Crystal.Guo@...iatek.com>
Subject: Re: [PATCH v2 2/3] dt-bindings: rng: update bindings for MediaTek
ARMv8 SoCs
Hi Sean,
On Thu, 2019-05-30 at 15:56 -0700, Sean Wang wrote:
> Hi, Neal
>
> On Mon, May 27, 2019 at 1:39 AM Neal Liu <neal.liu@...iatek.com> wrote:
> >
> > Document the binding used by the MediaTek ARMv8 SoCs random
> > number generator with TrustZone enabled.
> >
> > Signed-off-by: Neal Liu <neal.liu@...iatek.com>
> > ---
> > Documentation/devicetree/bindings/rng/mtk-rng.txt | 13 ++++++++++---
> > 1 file changed, 10 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/rng/mtk-rng.txt b/Documentation/devicetree/bindings/rng/mtk-rng.txt
> > index 2bc89f1..1fb9b1d 100644
> > --- a/Documentation/devicetree/bindings/rng/mtk-rng.txt
> > +++ b/Documentation/devicetree/bindings/rng/mtk-rng.txt
> > @@ -3,9 +3,12 @@ found in MediaTek SoC family
> >
> > Required properties:
> > - compatible : Should be
> > - "mediatek,mt7622-rng", "mediatek,mt7623-rng" : for MT7622
> > - "mediatek,mt7629-rng", "mediatek,mt7623-rng" : for MT7629
> > - "mediatek,mt7623-rng" : for MT7623
> > + "mediatek,mt7622-rng", "mediatek,mt7623-rng" for MT7622
> > + "mediatek,mt7629-rng", "mediatek,mt7623-rng" for MT7629
> > + "mediatek,mt7623-rng" for MT7623
>
> No make any change for those lines not belong to the series
There are some unused spaces and symbols. We try to align coding style
with other bindings.
>
> > + "mediatek,mtk-sec-rng" for MediaTek ARMv8 SoCs
>
> I thought "mediatek,mtk-sec-rng" is only for those MediaTek ARMv8 SoCs
> with security RNG
Yes, sure. It's better to describe with "MediaTek ARMv8 SoCs with
security RNG".
>
> > +
> > +Optional properties:
> > - clocks : list of clock specifiers, corresponding to
> > entries in clock-names property;
> > - clock-names : Should contain "rng" entries;
> > @@ -19,3 +22,7 @@ rng: rng@...0f000 {
> > clocks = <&infracfg CLK_INFRA_TRNG>;
> > clock-names = "rng";
> > };
>
> For those MediaTek ARMv8 SoCs with security RNG
Are you suggesting we create a new binding file with security RNG?
>
> > +
> > +hwrng: hwrng {
> > + compatible = "mediatek,mtk-sec-rng";
> > +};
> > --
> > 1.7.9.5
> >
Powered by blists - more mailing lists